`Development`: Refine user data export #1742

sachmii · 2026-01-20T10:35:12Z

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.

Motivation and Context

Closes #1695, needed to add interview data to user data export/

Description

Added interviewee data to applicant export and interview process/slot data to staff export (no IDs included)
Introduced new export DTOs for interview processes and interviewees; expanded interview slot DTO to include context fields without IDs
Extended interview repositories with queries needed to fetch interviewees and slots with job context
Updated export mapping logic to build interview process/slot data from fetched entities
Adjusted user data export tests to cover interview data and assert IDs are not present in the JSON

Steps for Testing

Prerequisites:

Log in to TumApply as admin, professor and applicant
Check that user data export works and contains only user-specific data

Review Progress

Code Review

Code Review 1

Manual Tests

Test 1

Test Coverage

Warning: Server tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-23 11:21:42 UTC

github-actions · 2026-01-20T10:36:22Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-20T10:44:15Z

@sachmii Test coverage has been automatically updated in the PR description.

github-actions · 2026-01-20T10:46:11Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-20T10:46:55Z

🤖 No OpenAPI or client changes needed.

Abi107717

Thank you for implementing this 😊Code LGTM, Just small comments, is there are a reason, that you are using NON_NULL instead of NON_EMPTY?

src/main/java/de/tum/cit/aet/core/dto/exportdata/IntervieweeExportDTO.java

src/main/java/de/tum/cit/aet/core/dto/exportdata/InterviewProcessExportDTO.java

src/main/java/de/tum/cit/aet/core/dto/exportdata/InterviewSlotExportDTO.java

…t/1695-add-interview-data-to-user-data-export

github-actions · 2026-01-22T17:50:44Z

@sachmii Test coverage has been automatically updated in the PR description.

github-actions · 2026-01-22T17:54:10Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-22T17:55:57Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Kiara65

Tested it on the testserver and the Interview Data is not included in the export data, thank you!

One thing I noticed is that the time in the export data differs from the time displayed for the Interview slots. I think they use different time zones, which can be confusing for the user. Maybe you could adjust it in the exported data or add a time zone there.

Another nitpick I noticed is that the times for the Interview data are in the format: "date T time Z". For the comments, the format "date T time" is used, without the Z at the end. This is not very important, just something I noticed for consistency 😄

Kiara65 · 2026-01-23T10:57:28Z

src/test/java/de/tum/cit/aet/core/web/UserDataExportResourceTest.java

+        InterviewProcess process = new InterviewProcess();
+        process.setJob(job);
+        process = interviewProcessRepository.save(process);
+
+        Interviewee interviewee = new Interviewee();
+        interviewee.setInterviewProcess(process);
+        interviewee.setApplication(application);
+        interviewee.setLastInvited(Instant.parse("2025-01-01T10:00:00Z"));
+        interviewee = intervieweeRepository.save(interviewee);
+
+        InterviewSlot slot = new InterviewSlot();
+        slot.setInterviewProcess(process);
+        slot.setInterviewee(interviewee);
+        slot.setStartDateTime(Instant.now().plusSeconds(3600));
+        slot.setEndDateTime(Instant.now().plusSeconds(7200));
+        slot.setLocation("Room 101");
+        slot.setStreamLink("https://stream.test/slot");
+        slot.setIsBooked(true);
+        interviewSlotRepository.save(slot);


Could you create test data for the interview data?
Maybe you could also open a new issue for the other interview service tests, since they don’t seem to use test data yet 😅 (Or adjust them as well in this PR, but this is not necessary)

I reworked the tests in my other PR #1755 and I don't create an interview data there.

sachmii · 2026-01-23T11:12:09Z

One thing I noticed is that the time in the export data differs from the time displayed for the Interview slots. I think they use different time zones, which can be confusing for the user. Maybe you could adjust it in the exported data or add a time zone there.

Another nitpick I noticed is that the times for the Interview data are in the format: "date T time Z". For the comments, the format "date T time" is used, without the Z at the end. This is not very important, just something I noticed for consistency 😄

Regarding the format, I will implement this in the #1755 PR.

Update: @Kiara65, I just implemented it in my latest commit in #1755.

…port

github-actions · 2026-01-23T11:21:44Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-23T11:22:19Z

🤖 No OpenAPI or client changes needed.

Kiara65

Thanks for the quick update, lgtm! 😄

refine user data export

b82e9e6

sachmii self-assigned this Jan 20, 2026

sachmii requested a review from az108 as a code owner January 20, 2026 10:35

sachmii linked an issue Jan 20, 2026 that may be closed by this pull request

Add interview data to user data export #1695

Open

github-actions bot added server Pull requests that update Java code. (Added Automatically!) tests labels Jan 20, 2026

sachmii added the ready for review label Jan 20, 2026

sachmii added 2 commits January 20, 2026 11:42

classify user

99855d6

add doc

f784f1e

sachmii requested a review from Bofan-Zhu January 20, 2026 10:44

Abi107717 requested changes Jan 22, 2026

View reviewed changes

sachmii added 2 commits January 22, 2026 18:50

fix include

2d06339

Merge branch 'main' of https://github.com/ls1intum/tum-apply into fea…

087b244

…t/1695-add-interview-data-to-user-data-export

sachmii requested a review from Abi107717 January 22, 2026 17:50

helios-aet bot temporarily deployed to test-server January 23, 2026 10:11 Inactive

sachmii added ready for merge PR is ready to merge and removed ready for review labels Jan 23, 2026

Kiara65 requested changes Jan 23, 2026

View reviewed changes

sachmii mentioned this pull request Jan 23, 2026

Development: Rework user data export server side #1755

Open

9 tasks

Merge branch 'main' into feat/1695-add-interview-data-to-user-data-ex…

8cf28af

…port

sachmii requested a review from Kiara65 January 23, 2026 11:26

Kiara65 approved these changes Jan 23, 2026

View reviewed changes

Development: Refine user data export #1742

Are you sure you want to change the base?

Development: Refine user data export #1742

Conversation

sachmii commented Jan 20, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Test Coverage

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Abi107717 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

Kiara65 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kiara65 Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

sachmii Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

sachmii commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

Kiara65 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`Development`: Refine user data export #1742

`Development`: Refine user data export #1742

sachmii commented Jan 20, 2026 •

edited by github-actions bot

Loading

Kiara65 left a comment •

edited

Loading

sachmii commented Jan 23, 2026 •

edited

Loading